Remove Vagrant-based Oracle XE setup#279
Merged
yahonda merged 1 commit intorsim:masterfrom May 5, 2026
Merged
Conversation
The Vagrant workflow is superseded by the .devcontainer/ setup added in rsim#276, which boots gvenzl/oracle-free in a container and provisions the same hr and arunit accounts the spec suite expects via the existing ci/setup_accounts.sh. Maintaining both paths is unnecessary; the Vagrant configuration also targets a CentOS 7.2 box and the Oracle XE 11.2.0 RPM, which is no longer readily distributable. Removed: - Vagrantfile - spec/support/file_check_script.sh — only invoked by the Vagrantfile to verify the Oracle XE installer was placed in the project root - spec/support/test_db.rb — only invoked under USE_VM_DATABASE=Y and hardcoded to the XE service, system/oracle credentials, and the /u01/app/oracle/oradata/XE paths inside the Vagrant box - USE_VM_DATABASE branches in spec/spec_helper.rb - .vagrant entry from .gitignore - Vagrant sections from README.md TESTS instructions History.txt entries that mention the Vagrant box are left as historical changelog records. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vagrantfileand the Vagrant-only support scripts (spec/support/file_check_script.sh,spec/support/test_db.rb).USE_VM_DATABASEbranches fromspec/spec_helper.rb, the.vagrantentry from.gitignore, and the Vagrant sections fromREADME.md..devcontainer/setup proposed in Add devcontainer environment and CI #276, which bootsgvenzl/oracle-freeand provisions thehr/arunitaccounts via the existingci/setup_accounts.sh.History.txtentries that mention the Vagrant box are left as historical changelog records.Test plan
.github/workflows/test.yml) is green — it does not exerciseUSE_VM_DATABASEand connects via the regularDATABASE_*env vars, so spec collection and execution should be unaffected.bundle exec rake -Tstill listsspeccleanly with no LoadError from removed support files.grep -r "USE_VM_DATABASE\|TestDb\|file_check_script\|vagrant" -- ':!History.txt'returns no matches.🤖 Generated with Claude Code